e2e: Replace logr.Logger with zap.SugaredLogger #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
e2e-zap-logger
branch
2 times, most recently
from
d8e86db to
51e2686
Compare
nirs
force-pushed
the
e2e-zap-logger
branch
2 times, most recently
from
f9c1b4c to
d57cfae
Compare
We used zap from controller runtime, returning logr.Logger. Replace it with zap SugaredLoger which is much nicer to use, supporting both structured and formatted logging and named log levels. We use the default development configuration which require no special setup. Replace the logs using string concatenation or fmt.Sprintf() with log.Infof() or log.Errorf(), using quoted arguments for more clear logs. Signed-off-by: Nir Soffer <[email protected]>
raghavendra-talur
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use zap from controller runtime, returning logr.Logger. Replace it
with zap SugaredLoger which is much nicer to use, supporting both
structured and formatted logging and named log levels.
We use the default development configuration which require no special
setup.
All the logs using string concatenation or fmt.Sprintf() replace with
log.Infof() and log.Errof() and use %q format for more clear logs.
Part of #1686